Ugly Code! » Uncategorized

appropriate method name

analytik — Wed, 14 Jul 2010 11:48:09 +0000

Company.Project.Tests.Listeningtool.IntegrationTest.ListeningToolBrandCategoryAndMentionsReportTest.Should_Add_a_Valid_File_And_The_MentionsByBrandAndCategoryReport_Should_Have_Any_Sentiment_Equal_To_Positive()

Or, if you prefer,

Company
 .Project
  .Tests
   .Listeningtool
    .IntegrationTest
     .ListeningToolBrandCategoryAndMentionsReportTest
      .Should_Add_a_Valid_File_And_The
       _MentionsByBrandAndCategoryReport_Should_Have
        _Any_Sentiment_Equal_To_Positive()

How to use Exceptions

analytik — Mon, 03 May 2010 13:55:02 +0000

   $error = false;
   try
   {
    $response = $comm->sendRequestToPaymentGate($this);
   }
   catch(Exception $e)
   {
    $error = $e;
    $response = null;
   }
   // Save the response's values
   $this->loadEnrollmentResponse($response);
  }
 
  // Save the progress so transaction process can be continued in the future
  $this->save();
 
  if($error !== false)
  {
   Mage::throwException($error->getMessage());
  }

As much as I love WordPress…

analytik — Sat, 24 Jan 2009 12:44:13 +0000

Seems that some WP developers are fans of refuctoring.

if ( ($fQ=strpos($Fid,'"'))!==false )
    $Fname = sanitize_title_with_dashes(substr( $Fid, $fQ+1, strpos($Fid,'"',$fQ+1)-$fQ-1 ));

### wrapped in  ?
   $p_offset = ($p_close < $p_open) ? $a-(strlen($part_content)-$p_open) : $a;

Argh. Guys, seriously, how about some objects? How about some readable variables? How about instead of nesting function calls and using ugly ternary operators… ugh. Nevermind.

Hardcoding FTW

analytik — Sat, 29 Nov 2008 18:19:19 +0000

function _getCRServices($data)
  {
    if (is_array($data)) {
      //this is ehmmmm, d*ment requirement from client
      $not_cr = array(3006, 2416, 1026, 5604, 3501);
      ...
    }
  }

Makes one wonder if there was a demented requirement, or just a demented programming technique.

Who likes ugly hacks?

analytik — Sun, 28 Sep 2008 21:44:41 +0000

According to my search, a lot of people do.

#ugly hack
self.log.info("Running script")
dict={ 'self' : self.model,
'model' : self.model,
'interpreter': self }
exec(self.script,dict)

// Ugly hack
Class.forName("tristero.util.Conduit");
Class.forName("tristero.util.Lock");
Class.forName("tristero.util.PumpListener");
Class.forName("tristero.util.StringUtils");

_label.Show();
_label.Hide(); // Ugly hack!
base.Show();

 /*
UGLY UGLY UGLY HACK !!!
*/
QFile inFile(uisFile);
if (!inFile.open(QIODevice::ReadOnly | QIODevice::Text))
return;
 
QFile outFile("/tmp/temp.ini");
if (!outFile.open(QIODevice::WriteOnly | QIODevice::Text))
return;
QTextStream in(&inFile);
QTextStream out(&outFile);
 
while (!in.atEnd())
{
QString line = in.readLine();
line.replace("\\","\\\\");
out << line << endl;
}
inFile.close();
outFile.close();
/*
END OF UGLY UGLY UGLY HACK
*/

 // ugly, ugly hack
if(adapterUse.getAdapterIfKnown()== SwaRefAdapter.class) {
programElement.annotate(XmlAttachmentRef.class);
} else {
// [RESULT]
// @XmlJavaTypeAdapter( Foo.class )
programElement.annotate2(XmlJavaTypeAdapterWriter.class).value(
adapterUse.adapterType.toType(outline,EXPOSED));
}

Of course, these doesn’t provide fun nor educational value. But one thing is obvious: ugly code is here to stay. Hopefully I’ll be able to find some more entertaining pieces next time.